Revised Module: Small Village Woes (1.24)

[Legacy_MagicalMaster]

               

Link the script, please.

 

I'm *guessing* you have

 

if (GetLevelByClass(CLERIC) == 1)  blah blah

 

when you just neeed

 

if (GetLevelByClass(CLERIC)) blah blah

 

Obviously that's not the actual code but that would match your problem.

               
               

               
            

[Legacy_BortSonofBort]

               

As indicated below, I don't currently have the script looking for a set Class Level in the "Text Appears When..." field. My thinking was the script would simply identify any level of the class and return TRUE when needed, which is what I'm looking to do with the script.

 

Thanks for the help clearing this up!

 

Discount Price Script:

#include "nw_i0_tool"

int nWizard = CLASS_TYPE_WIZARD;
int nSorcerer = CLASS_TYPE_SORCERER;

int StartingConditional()
{
object oPC = GetPCSpeaker();
if(GetGold(oPC) > 24 && (GetLevelByClass(nWizard, oPC) || GetLevelByClass(nSorcerer, oPC)))

return TRUE;

return FALSE;
}

Full Price Script:

#include "nw_i0_tool"

int nWizard = CLASS_TYPE_WIZARD;
int nSorcerer = CLASS_TYPE_SORCERER;

int StartingConditional()
{
object oPC = GetPCSpeaker();
if(GetGold(oPC) < 50 || GetLevelByClass(nWizard, oPC) == TRUE || GetLevelByClass(nSorcerer, oPC) == TRUE)

return FALSE;

return TRUE;
}

               
               

               
            

[Legacy_MagicalMaster]

               

What exactly is the behavior that you're seeing?

 

Also, try changing

 

if(GetGold(oPC) < 50 || GetLevelByClass(nWizard, oPC) == TRUE || GetLevelByClass(nSorcerer, oPC) == TRUE)

 

to

 

if(GetGold(oPC) < 50 || GetLevelByClass(nWizard, oPC) || GetLevelByClass(nSorcerer, oPC))

 

and see if that helps.

               
               

               
            

[Legacy_BortSonofBort]

               

What I'm seeing is when a PC of these class types is beyond Level 1, the class check doesn't work, and all dialogue-based purchase options are visible depending on if they do or don't have enough money to purchase the item (which you experienced, I believe MM, in your play-through of the module). If a PC of these class types is level 1, the scripts function as intended.


For all non-affiliated PCs of all other class types, the scripts function as intended.

 

(I have not tried your above suggestion yet.)

               
               

               
            

[Legacy_MagicalMaster]

               

Did a quick test during lunch break -- TRUE is read as 1 only.  In the test I got the following...

 

3 != TRUE

1 == TRUE

0 != TRUE

 

The last result is obvious but the first is not.  So the change I made above will fix your problem, I think.

               
               

               
            

[Legacy_BortSonofBort]

               

Did a quick test during lunch break -- TRUE is read as 1 only.  In the test I got the following...

 

3 != TRUE

1 == TRUE

0 != TRUE

 

The last result is obvious but the first is not.  So the change I made above will fix your problem, I think.

 

So, I should change the " == TRUE)" portion of the script to "3 != TRUE"?


My apologies for the silly question. I stopped coding in 2002 to embark on a theatre acting and directing career, so there are still many cobwebs yet to be cleaned up in my memory of the aurora scripting language. '> And actually, editing my previous script examples with your code changes would probably be best for a big dumb jerk like me. '>

 

Thanks for the follow-up assistance in advance!

 

               
               

               
            

[Legacy_MagicalMaster]

               

No, the "change above" refers to this post.

               
               

               
            

[Legacy_BortSonofBort]

               

Thank ye!

               
               

               
            

[Legacy_BortSonofBort]

               Small Village Woes v1.30 Update | 7.1.04 [SPOILERS BELOW]:


Once again, most of my time today was spent focusing on the various merchants, but some other edits were made, too.

Merchant Fixes - Detail work.


a.) Witch Wizard/Sorcerer alignment discount error fixed. (Thanks, MM!)

b.) Fixed Willy sell-back items error. (*see below for more info.)

c. Fixed Brother Billy ACT 1 cleric/paladin alignment discount error. (Thanks, MM!)

d.) Brother Billy ACT 3 merchant dialogue options fixed.

e.) Capped merchant spell scrolls at Level 6. Removed higher level spell scrolls than 6.

f.) Witch now lists price of sellable undead parts.

g.) Witch and Billy reference not needing to cleanse undead parts before selling them.

h.) Increased price of Fireball Scroll, Decreased price of Sanctuary Scroll.

i.) Copied some formatting examples between all of the merchants to help make the system look more uniform.

ADDITIONAL NOTES -


a.) The merchant alignment fix came from deleting the "== TRUE" portion of the script.


(*Sell-back error: MM, I tested selling back the great ax and long sword, and both worked for me. Considering that you possibly meant the looted Br'ei ax and sword, I tested those as well. I was able to sell back all items except for the "Women's Clothing" that you mentioned.)


I'm very close to finishing up with these initial notes (mostly by MM). I'm very excited to release another BETA build soon for further review. Clearly, this module has never had this degree of polish.
               
               

               
            

[Legacy_MagicalMaster]

               

Considering that you possible meant the looted Br'ei ax and sword, I tested those as well.

 

Don't know what to tell you.

 

Could only sell the crossbow.

               
               

               
            

[Legacy_BortSonofBort]

               I love screenshots! I'll look it over again.


Your help stamping out these bugs is more appreciated than you might possibly know.
               
               

               
            

[Legacy_MagicalMaster]

               

Is it possible you changed one of the scripts dealing with this?  It IS possible that your version works but my (older) one does not.

 

And perhaps, but I know firsthand how aggravating bugs are '>  Trying to squash one right now in my own module.

               
               

               
            

[Legacy_Bort_Son_of_Bort]

               

Is it possible you changed one of the scripts dealing with this?  It IS possible that your version works but my (older) one does not.

 

And perhaps, but I know firsthand how aggravating bugs are '>  Trying to squash one right now in my own module.

 

I think what's more likely is that I have two instances of the Br'ei Ax and Sword that I didn't realize were in the game, and I'm checking the blueprint res ref of the wrong versions. Unfortunately, I only have a MAC laptop at home, so I have to wait until I go to work tomorrow.


Oh, I'm sure you do know how aggravating they are. But it's not just bugs to me. It's more about putting in the effort to help me maximize the quality of this module twelve years later after its original release. My reason for bringing this back around was to maximize it in its current form so I could put it to bed, which as I'm experiencing it, would not be possible without your input.

               
               

               
            

[Legacy_MagicalMaster]

               

It's possible about the instances -- those two are from the inn, if it helps.

 

And happy to help -- I'm not kidding when I say this game quite literally changed my life, shifted me from a future in law to "You know, this programming stuff is kind of interesting...maybe I should make a career out of it."

               
               

               
            

[Legacy_werelynx]

               

Just a question: if I have a halfling, would I be able to sell greatsword if I can't wield it?