wand/potion making

[Legacy_acomputerdood]

               so, i have a spell remove blindness/deafness, that can't be made into a wand.  i'm guessing it has something to do with the script itself.  what's the mechanism/trigger to allow a spell be made into a potion/wand?  is there a problem with below script:

//::///////////////////////////////////////////////
//:: Remove Effects
//:: NW_SO_RemEffect
//:: Copyright © 2001 Bioware Corp.
//:://////////////////////////////////////////////
/*
ﾃつ  ﾃつ  Takes the place of
ﾃつ  ﾃつ  ﾃつ  ﾃつ  Remove Disease
ﾃつ  ﾃつ  ﾃつ  ﾃつ  Neutralize Poison
ﾃつ  ﾃつ  ﾃつ  ﾃつ  Remove Paralysis
ﾃつ  ﾃつ  ﾃつ  ﾃつ  Remove Curse
ﾃつ  ﾃつ  ﾃつ  ﾃつ  Remove Blindness / Deafness
*/
//:://////////////////////////////////////////////
//:: Created By: Preston Watamaniuk
//:: Created On: Jan 8, 2002
//:://////////////////////////////////////////////
#include "wm_include"
#include "NW_I0_SPELLS"
#include "ww_inc"
//#include "x2_inc_spellhook"




void main(){
ﾃつ  ﾃつ  if (WildMagicOverride()) { return; }
ﾃつ  ﾃつ  SendMessageToPC(OBJECT_SELF, "remeffect");
ﾃつ  ﾃつ  //Declare major variables
ﾃつ  ﾃつ  int nSpellID = GetSpellId();
ﾃつ  ﾃつ  object oTarget = GetSpellTargetObject();
ﾃつ  ﾃつ  int nEffect1;
ﾃつ  ﾃつ  int nEffect2;
ﾃつ  ﾃつ  int nEffect3;
ﾃつ  ﾃつ  effect eVis = EffectVisualEffect(VFX_IMP_REMOVE_CONDITION);
ﾃつ  ﾃつ  //Check for which removal spell is being cast.
ﾃつ  ﾃつ  if(nSpellID == SPELL_REMOVE_BLINDNESS_AND_DEAFNESS)
ﾃつ  ﾃつ  {
ﾃつ  ﾃつ  ﾃつ  ﾃつ  nEffect1 = EFFECT_TYPE_BLINDNESS;
ﾃつ  ﾃつ  ﾃつ  ﾃつ  nEffect2 = EFFECT_TYPE_DEAF;
ﾃつ  ﾃつ  }
ﾃつ  ﾃつ  else if(nSpellID == SPELL_REMOVE_CURSE)
ﾃつ  ﾃつ  {
ﾃつ  ﾃつ  ﾃつ  ﾃつ  nEffect1 = EFFECT_TYPE_CURSE;
ﾃつ  ﾃつ  ﾃつ  ﾃつ  // Remove PC Lycanthropy
ﾃつ  ﾃつ  ﾃつ  ﾃつ  if(GetLocalInt(oTarget,"AFF_WEREWOLF")) CureWerewolf(oTarget,3);
ﾃつ  ﾃつ  }
ﾃつ  ﾃつ  else if(nSpellID == SPELL_REMOVE_DISEASE || nSpellID == SPELLABILITY_REMOVE_DISEASE)
ﾃつ  ﾃつ  {
ﾃつ  ﾃつ  ﾃつ  ﾃつ  nEffect1 = EFFECT_TYPE_DISEASE;
ﾃつ  ﾃつ  ﾃつ  ﾃつ  nEffect2 = EFFECT_TYPE_ABILITY_DECREASE;
ﾃつ  ﾃつ  ﾃつ  ﾃつ  // Remove PC Lycanthropy
ﾃつ  ﾃつ  object oToken = GetItemPossessedBy(oTarget,"DALA_CONVERTED");
ﾃつ  ﾃつ  if(GetLocalInt(oToken,"AFF_WEREWOLF"))CureWerewolf(oTarget,2,OBJECT_SELF);
ﾃつ  ﾃつ  }
ﾃつ  ﾃつ  else if(nSpellID == SPELL_NEUTRALIZE_POISON)
ﾃつ  ﾃつ  {
ﾃつ  ﾃつ  ﾃつ  ﾃつ  nEffect1 = EFFECT_TYPE_POISON;
ﾃつ  ﾃつ  ﾃつ  ﾃつ  nEffect2 = EFFECT_TYPE_DISEASE;
ﾃつ  ﾃつ  ﾃつ  ﾃつ  nEffect3 = EFFECT_TYPE_ABILITY_DECREASE;
ﾃつ  ﾃつ  }




ﾃつ  ﾃつ  //Fire cast spell at event for the specified target
ﾃつ  ﾃつ  SignalEvent(oTarget, EventSpellCastAt(OBJECT_SELF, nSpellID, FALSE));
ﾃつ  ﾃつ  //Remove effects
ﾃつ  ﾃつ  RemoveSpecificEffect(nEffect1, oTarget);
ﾃつ  ﾃつ  if(nEffect2 != 0)
ﾃつ  ﾃつ  {
ﾃつ  ﾃつ  ﾃつ  ﾃつ  RemoveSpecificEffect(nEffect2, oTarget);
ﾃつ  ﾃつ  }
ﾃつ  ﾃつ  if(nEffect3 != 0)
ﾃつ  ﾃつ  {
ﾃつ  ﾃつ  ﾃつ  ﾃつ  RemoveSpecificEffect(nEffect3, oTarget);
ﾃつ  ﾃつ  }
ﾃつ  ﾃつ  ApplyEffectToObject(DURATION_TYPE_INSTANT, eVis, oTarget);
}






obviously, this part fires:

    SendMessageToPC(OBJECT_SELF, "remeffect");

when trying to make a potion, but then nothing happens.  no feedback messages.  it doesn't even check for gold because i can attempt with 0 gold and it gives no warning.
               
               

               

                     Modifiﾃδｩ par acomputerdood, 02 fﾃδｩvrier 2013 - 06:49 .
                     
                  

            

[Legacy_Lightfoot8]

               is it listed in iprp_spells.2da
               
               

               
            

[Legacy_Shadooow]

               actually the reason this spell cannot be craft is in script

each script must have this line inside and at the top to allow bioware spell imbuing:

   if (!X2PreSpellCastCode())
   {
   // If code within the PreSpellCastHook (i.e. UMD) reports FALSE, do not run this spell
       return;
   }
               
               

               
            

[Legacy_henesua]

                Lightfoot8 nailed it (as usual)
iprp_spells.2da is the place to define spell properties that can be added to items.
The Krit created an improved framework for this process as well with A Better Craft Magic. You still need to use iprp_spells.2da, but his system opens up much more flexibility for item crafting in game.

Also, as an aside, for allowing players to cast a spell on an item you need to edit
des_crft_spells.2da


edit... and lastly  yes, that spellhook is essential. Thanks, ShaDoOoW, for catching that.
               
               

               

                     Modifiﾃδｩ par henesua, 02 fﾃδｩvrier 2013 - 07:34 .